add actions to state-badge element and state-label-badge (default Lovelace badge type)#4028
Merged
Merged
Conversation
Member
Author
|
will wait for home-assistant/home-assistant.io#10834 to be merged before adding docs |
bramkragten
reviewed
Oct 18, 2019
bramkragten
reviewed
Oct 18, 2019
bramkragten
reviewed
Oct 18, 2019
Member
|
How many places use |
Member
Author
Agreed |
state-label-badge no longer handles clicks added actions to hui-state-label-badge moved ha-badges-card to Lit
Member
Author
|
Went with a different approach and as suggested have the parent handling click events. I realized 3/4 the way through moving ha-badges-card to Lit that it was part of States, 🤷♂️ In doing this I also decided to add actions to badges 🎉 |
iantrich
changed the title
2 tasks
bramkragten
approved these changes
Oct 21, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs: home-assistant/home-assistant.io#10915