Standardize times in time sensors Jewish calendar

[tsvi]

Breaking Change:

The output of the timestamp sensors have been streamlined so they're easier to use in automations. All the timestamp sensors will return UTC time in ISO 8601 format.
Attributes have been added to get a UNIX timestamp.

Please note if you have any automations relying on the timestamp, you'll need to update them to compare to the UTC timestamp.

Description:

This standardizes the times in the timestamp sensors for the Jewish calendar, times like candle lighting, havdalah etc. are all defined as timestamp sensors. As such, their state will show ISO8601 UTC timestamps.
Also, timestamp attributes have been added to the sensor. This should allow easier automation triggers and conditions when comparing timestamps.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10463

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• Documentation added/updated in home-assistant.io
• Tests have been added to verify that the new code works.

[mikeage]

Nice idea. We make "early shabbat" during DST (well, mostly; we stopped a few weeks ago), so I created my own issur_melacha sensor based on plag hamincha on Friday, and the conversion to compare the current time with plag as a timestamp was a bit of an exercise in Jinja and figuring out what's what. This will make that sort of thing much easier :-)

[tsvi]

I'm closing this pull request for now. I'm trying to envision what I would like ultimately to be possible and I think it will need some other PR's first.

Ultimately, I would like to reach a point where I could write the following automation:

automation:
  trigger:
    platform: time
    at: "{{ states('sensor.timestamp_based_sensor') }}"
    offset:
      minutes: -15

@balloob would you consider such a PR? Or am I in the wrong direction, I suppose this would mean opening up an architecture issue?

[balloob]

Yeah I would consider such a PR . It might be better to just have time trigger be aware of timestamp device classes sensors. That way the UI could offer a dropdown.

[MartinHjelmare]

Thanks!