Skip to content

New version of rainbird component#10326

Merged
frenck merged 12 commits into
home-assistant:nextfrom
konikvranik:patch-1
Oct 1, 2019
Merged

New version of rainbird component#10326
frenck merged 12 commits into
home-assistant:nextfrom
konikvranik:patch-1

Conversation

@konikvranik
Copy link
Copy Markdown
Contributor

@konikvranik konikvranik commented Sep 9, 2019

Description:
see home-assistant/core#26393

Pull request in home-assistant (if applicable): home-assistant/core#26393

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Sep 9, 2019
@klaasnicolaas klaasnicolaas added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed labels Sep 9, 2019
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, @konikvranik, thanks for the PR. I've reviewed it and left a comment. Could you please take a look? Thanks! 👍

Comment thread source/_components/rainbird.markdown Outdated
@frenck frenck added in-progress This PR/Issue is currently being worked on and removed ready-for-review This PR needs to be reviewed labels Sep 10, 2019
Comment thread source/_components/rainbird.markdown Outdated
Comment thread source/_components/rainbird.markdown
@probot-home-assistant probot-home-assistant Bot added the parent-merged The parent PR has been merged already label Sep 26, 2019
Comment thread source/_components/rainbird.markdown Outdated
Comment thread source/_components/rainbird.markdown Outdated
Comment thread source/_components/rainbird.markdown Outdated
konikvranik and others added 3 commits September 26, 2019 12:00
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @konikvranik! 👍

🎉

@frenck frenck merged commit d2f6520 into home-assistant:next Oct 1, 2019
@probot-home-assistant probot-home-assistant Bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants