Skip to content

Transmission config flow#10293

Merged
frenck merged 3 commits into
home-assistant:nextfrom
engrbm87:patch-2
Oct 1, 2019
Merged

Transmission config flow#10293
frenck merged 3 commits into
home-assistant:nextfrom
engrbm87:patch-2

Conversation

@engrbm87
Copy link
Copy Markdown
Contributor

@engrbm87 engrbm87 commented Sep 4, 2019

Description:
Configure Transmission through config flow.

Pull request in home-assistant (if applicable): home-assistant/core#26434

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

Configure Transmission using config flow.
@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Sep 4, 2019
@klaasnicolaas klaasnicolaas added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed labels Sep 4, 2019
klaasnicolaas
klaasnicolaas previously approved these changes Sep 4, 2019
@klaasnicolaas klaasnicolaas added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Sep 4, 2019
@klaasnicolaas
Copy link
Copy Markdown
Member

✅ Approved. Can be merged as soon as the parent PR gets merged 👍

@frenck frenck reopened this Sep 17, 2019
@probot-home-assistant probot-home-assistant Bot added the parent-merged The parent PR has been merged already label Sep 26, 2019
@MartinHjelmare MartinHjelmare removed the awaits-parent Awaits the merge of an parent PR label Sep 26, 2019
Comment thread source/_components/transmission.markdown Outdated
@engrbm87
Copy link
Copy Markdown
Contributor Author

I think we need to edit the description related to the monitored_conditions as they are no longer configured through configuration.yaml or imported.

@frenck
Copy link
Copy Markdown
Member

frenck commented Sep 26, 2019

@engrbm87 It can simply be removed, right?

@engrbm87
Copy link
Copy Markdown
Contributor Author

@engrbm87 It can simply be removed, right?

Yes we can remove it. We can mention that the following sensors will be automatically added. And we need to add the start/stop all torrents switch which wasn't there before.

Copy link
Copy Markdown
Member

frenck commented Sep 26, 2019

Could you please update the documentation accordingly? Thanks 👍

Removed monitored conditions and updated list of entities added by the integration
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustments @engrbm87! 👍

@frenck frenck dismissed MartinHjelmare’s stale review October 1, 2019 10:08

comments addressed

@frenck frenck merged commit ef8a574 into home-assistant:next Oct 1, 2019
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants