Skip to content

Add ViCare component documentation#10211

Merged
frenck merged 10 commits into
home-assistant:nextfrom
oischinger:patch-1
Sep 7, 2019
Merged

Add ViCare component documentation#10211
frenck merged 10 commits into
home-assistant:nextfrom
oischinger:patch-1

Conversation

@oischinger
Copy link
Copy Markdown
Contributor

@oischinger oischinger commented Aug 22, 2019

Description:

This PR adds documentation for the Viessmann ViCare climate component.

Pull request in home-assistant (if applicable): home-assistant/core#26151

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Aug 22, 2019
@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Aug 22, 2019
@oischinger oischinger changed the title Patch 1 Add ViCare component documentation Aug 22, 2019
@klaasnicolaas klaasnicolaas added new-integration This PR adds documentation for a new Home Assistant integration ready-for-review This PR needs to be reviewed labels Aug 22, 2019
Comment thread source/_components/vicare.markdown Outdated
Comment thread source/_components/vicare.markdown Outdated
Comment thread source/_components/vicare.markdown Outdated
Comment thread source/_components/vicare.markdown Outdated
@klaasnicolaas klaasnicolaas added in-progress This PR/Issue is currently being worked on and removed ready-for-review This PR needs to be reviewed labels Aug 22, 2019
More documentation on services
Comment thread source/_components/vicare.markdown Outdated
Comment thread source/_components/vicare.markdown
Added missing configuration parameter. Thanks @klaasnicolaas
@probot-home-assistant probot-home-assistant Bot added the parent-merged The parent PR has been merged already label Sep 6, 2019
Comment thread source/_components/vicare.markdown Outdated
Comment thread source/_components/vicare.markdown Outdated
Comment thread source/_components/vicare.markdown Outdated
Comment thread source/_components/vicare.markdown Outdated
Comment thread source/_components/vicare.markdown Outdated
Comment thread source/_components/vicare.markdown Outdated
Comment thread source/_components/vicare.markdown Outdated
Comment thread source/_components/vicare.markdown Outdated
MartinHjelmare
MartinHjelmare previously approved these changes Sep 6, 2019
@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Sep 7, 2019
@frenck frenck dismissed klaasnicolaas’s stale review September 7, 2019 20:02

comments addressed

@frenck
Copy link
Copy Markdown
Member

frenck commented Sep 7, 2019

Thanks for making it perfect @oischinger! 👍

Let's merge this in! 🎉

@frenck frenck merged commit f7899af into home-assistant:next Sep 7, 2019
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Sep 7, 2019
@bbrendon bbrendon mentioned this pull request Sep 23, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants