Add Viessmann ViCare Climate platform#26151
Merged
Merged
Conversation
Contributor
|
Hi @oischinger, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
2 tasks
e2ab42f to
d6d2fec
Compare
d6d2fec to
6ef8805
Compare
MartinHjelmare
requested changes
Aug 31, 2019
Update to latest PyVicare (0.1.0)
Contributor
Author
|
Thanks for the review @MartinHjelmare and helpful comments! I still need to update the docs anyway. |
MartinHjelmare
requested changes
Aug 31, 2019
Member
|
Please run script/gen_requirements_all.py and commit the changes. |
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Just a couple small fixes left.
Member
|
Can be merged when build passes. |
Contributor
Author
|
@MartinHjelmare thanks a lot for your support (and patience). I'll update the docs PR now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for the Viessmann ViCare climate component. Previously available as a custom component here: https://github.com/oischinger/ha_vicare
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10211
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: