Skip to content

Add Viessmann ViCare Climate platform#26151

Merged
MartinHjelmare merged 8 commits into
home-assistant:devfrom
oischinger:vicare_climate
Sep 6, 2019
Merged

Add Viessmann ViCare Climate platform#26151
MartinHjelmare merged 8 commits into
home-assistant:devfrom
oischinger:vicare_climate

Conversation

@oischinger
Copy link
Copy Markdown
Contributor

@oischinger oischinger commented Aug 22, 2019

Description:

This PR adds support for the Viessmann ViCare climate component. Previously available as a custom component here: https://github.com/oischinger/ha_vicare

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10211

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @oischinger,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Comment thread homeassistant/components/vicare/climate.py Outdated
Comment thread homeassistant/components/vicare/climate.py Outdated
Comment thread homeassistant/components/vicare/climate.py Outdated
Comment thread homeassistant/components/vicare/climate.py Outdated
Comment thread homeassistant/components/vicare/climate.py Outdated
Comment thread homeassistant/components/vicare/climate.py Outdated
Comment thread homeassistant/components/vicare/climate.py Outdated
Comment thread homeassistant/components/vicare/climate.py Outdated
Comment thread homeassistant/components/vicare/climate.py Outdated
Comment thread homeassistant/components/vicare/climate.py Outdated
Update to latest PyVicare (0.1.0)
@oischinger
Copy link
Copy Markdown
Contributor Author

Thanks for the review @MartinHjelmare and helpful comments!
I refactored the water component into water_heater.py. Should this be made a seperate PR or is it ok to be in this one?

I still need to update the docs anyway.

Comment thread homeassistant/components/vicare/climate.py Outdated
Comment thread homeassistant/components/vicare/water_heater.py Outdated
Comment thread homeassistant/components/vicare/water_heater.py Outdated
Comment thread homeassistant/components/vicare/water_heater.py Outdated
Comment thread homeassistant/components/vicare/water_heater.py Outdated
Comment thread homeassistant/components/vicare/water_heater.py Outdated
Comment thread homeassistant/components/vicare/water_heater.py Outdated
Comment thread homeassistant/components/vicare/water_heater.py Outdated
Comment thread homeassistant/components/vicare/water_heater.py Outdated
Comment thread homeassistant/components/vicare/climate.py Outdated
Comment thread homeassistant/components/vicare/__init__.py Outdated
Comment thread homeassistant/components/vicare/climate.py Outdated
Comment thread homeassistant/components/vicare/climate.py Outdated
Comment thread homeassistant/components/vicare/climate.py Outdated
Comment thread homeassistant/components/vicare/__init__.py Outdated
Comment thread homeassistant/components/vicare/__init__.py
Comment thread .coveragerc Outdated
@MartinHjelmare
Copy link
Copy Markdown
Member

Please run script/gen_requirements_all.py and commit the changes.

Comment thread homeassistant/components/vicare/climate.py Outdated
Comment thread homeassistant/components/vicare/climate.py Outdated
Comment thread homeassistant/components/vicare/climate.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small fixes left.

Comment thread homeassistant/components/vicare/climate.py Outdated
Comment thread homeassistant/components/vicare/climate.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Copy Markdown
Member

Can be merged when build passes.

@oischinger
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare thanks a lot for your support (and patience). I'll update the docs PR now.

@MartinHjelmare MartinHjelmare merged commit a72d9da into home-assistant:dev Sep 6, 2019
@lock lock Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants