Consider default_view as view by default.

[andrey-git]

Consider default_view as view by default.

Will allow to use home-assistant/frontend#244 without manually specifying view: true under default_view

[mention-bot]

@andrey-git, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob to be a potential reviewer.

[balloob]

You test entity.attributes.view !== false, which is equivalent to testing entity.attributes.view which is what we do in the first part of this logical expression.

[andrey-git]

Hm, actually it either true or undefined, no way for it to be false (it just won't be set in group.py)

I removed the extra check. Now default_view is always considered a view.

[balloob]

As far as I know, the default view is specified via the groups command and thus will always have view: true

[balloob]

If people don't set view: true in their config, it's a configuration problem. We should not try to fix this here because that means that we will have to fix it in every UI. Instead, the user has to configure it correctly.

[andrey-git]

The current UI works fine without view: true on default_view.

This function will consider it non-view, but partial-cards.html check by entity id.

Should I add a voluptuous check instead that default_view must have view: true?

I think it is extra-verbose :)

[balloob]

Yes, a voluptuous check is the right place. We should never fight symptoms but instead solve things at the source.

[andrey-git]

Created home-assistant/core#6758 instead.