Treat default_view as view by default

[andrey-git]

Description:

Treat default_view as view by default
Redo of home-assistant/home-assistant-js-websocket/pull/6

If the code does not interact with devices:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• Tests have been added to verify that the new code works.

[mention-bot]

@andrey-git, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @pvizeli and @fabaff to be potential reviewers.

[balloob]

I don't think that this is the right solution either. We should raise an error or else people might be confused on how to specify a view because there are two ways.

We should also test this.

[andrey-git]

I will add tests, but requiring view: true for default_view would be a breaking change. What is the benefit of forcing a more verbose syntax on the user?

[balloob]

Both approaches will be breaking changes. Because someone might want to have a group called default_view and use it as a group (I doubt it though).

I don't like auto-fixing config because it is a slippery slope. We start auto fixing more and more and all of a sudden we get into a situation where 2 auto-fixes collide and we have to start making a decision that can break things for some users… so better to never auto fix.

[andrey-git]

So maybe make a fix in a different direction - make default_view without view: true behave like a regular non-view group? This way it would be consistent, and default_view wouldn't be a magic name in the backend, just in the frontend.

[balloob]

Isn't it already treated as a non-view group ?

[andrey-git]

HAWS.extractViews won't consider it a view, but the code that pulls all states won't run: https://github.com/home-assistant/home-assistant-polymer/blob/master/src/layouts/partial-cards.html#L304-L316

Instead this will run (despite the group not being a view):
https://github.com/home-assistant/home-assistant-polymer/blob/master/src/layouts/partial-cards.html#L321-L322

[balloob]

Good point! Yes, we should update those pieces of code.

[andrey-git]

Created home-assistant/frontend#251