Add UI for Z-Wave JS Device Reinterview#8957
Merged
balloob merged 11 commits intohome-assistant:devfrom Apr 27, 2021
Merged
Conversation
bramkragten
reviewed
Apr 22, 2021
bramkragten
reviewed
Apr 22, 2021
bramkragten
reviewed
Apr 22, 2021
bramkragten
reviewed
Apr 22, 2021
bramkragten
reviewed
Apr 22, 2021
bramkragten
reviewed
Apr 22, 2021
bramkragten
reviewed
Apr 22, 2021
Contributor
|
Just a thought - you may want to indicate in the pop up that if the user closes the modal, the re-interview will continue in the background. It currently seems like you have to sit there and wait |
bramkragten
reviewed
Apr 26, 2021
Member
Author
bramkragten
reviewed
Apr 26, 2021
bramkragten
reviewed
Apr 26, 2021
bramkragten
approved these changes
Apr 26, 2021
dd28673 to
293ceb6
Compare
Member
|
I don't think that we should show the |
Member
Author
|
Once we get a few more buttons on that page I'll want to reconfigure the layout a bit. Re-interview isn't really destructive so no harm in someone running it unnecessarily. Not sure it makes sense at the moment to hide a single button behind an overflow. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed change
Add a UI for re-interviewing a Z-Wave JS device.
Depends on home-assistant/core#49024
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: