Skip to content

Add UI for Z-Wave JS Device Reinterview#8957

Merged
balloob merged 11 commits intohome-assistant:devfrom
cgarwood:zwjs_reinterview
Apr 27, 2021
Merged

Add UI for Z-Wave JS Device Reinterview#8957
balloob merged 11 commits intohome-assistant:devfrom
cgarwood:zwjs_reinterview

Conversation

@cgarwood
Copy link
Copy Markdown
Member

Proposed change

Add a UI for re-interviewing a Z-Wave JS device.

Depends on home-assistant/core#49024

ReinterviewNode

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@raman325
Copy link
Copy Markdown
Contributor

Just a thought - you may want to indicate in the pop up that if the user closes the modal, the re-interview will continue in the background. It currently seems like you have to sit there and wait

Comment thread src/data/zwave_js.ts Outdated
@cgarwood
Copy link
Copy Markdown
Member Author

Updated recording of the reinterview process:
Untitled Project

@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 27, 2021

I don't think that we should show the re-interview button as a major option on the device page. This should be in an overflow menu or something. It's too appealing to press even if it should be seen as a last resort.

@cgarwood
Copy link
Copy Markdown
Member Author

Once we get a few more buttons on that page I'll want to reconfigure the layout a bit. Re-interview isn't really destructive so no harm in someone running it unnecessarily. Not sure it makes sense at the moment to hide a single button behind an overflow.

@balloob balloob merged commit 83e65e2 into home-assistant:dev Apr 27, 2021
@balloob balloob mentioned this pull request Apr 28, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants