Skip to content

Add subscription for Z-Wave JS node re-interview status#49024

Merged
cgarwood merged 6 commits intohome-assistant:devfrom
cgarwood:zwjs_reinterview_ws
Apr 21, 2021
Merged

Add subscription for Z-Wave JS node re-interview status#49024
cgarwood merged 6 commits intohome-assistant:devfrom
cgarwood:zwjs_reinterview_ws

Conversation

@cgarwood
Copy link
Copy Markdown
Member

@cgarwood cgarwood commented Apr 10, 2021

Proposed change

Update the refresh_node_info (reinterview) websocket API to be subscription-based and forward interview status events to the frontend.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@cgarwood cgarwood marked this pull request as draft April 10, 2021 19:35
@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with an integration (zwave_js) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@cgarwood cgarwood force-pushed the zwjs_reinterview_ws branch 2 times, most recently from 98979cd to 93760b8 Compare April 20, 2021 23:42
@cgarwood cgarwood marked this pull request as ready for review April 21, 2021 00:49
Comment thread homeassistant/components/zwave_js/api.py
Comment thread homeassistant/components/zwave_js/api.py Outdated
@MartinHjelmare
Copy link
Copy Markdown
Member

There's a merge conflict.

Comment thread tests/components/zwave_js/test_api.py
@cgarwood cgarwood force-pushed the zwjs_reinterview_ws branch from acb0cc3 to b677ba0 Compare April 21, 2021 10:20
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cgarwood cgarwood merged commit cad281b into home-assistant:dev Apr 21, 2021
@cgarwood cgarwood deleted the zwjs_reinterview_ws branch April 21, 2021 11:35
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants