Skip to content

Highlight if log comes from custom component#8912

Merged
balloob merged 4 commits intodevfrom
logs-custom-component
Apr 14, 2021
Merged

Highlight if log comes from custom component#8912
balloob merged 4 commits intodevfrom
logs-custom-component

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 14, 2021

Breaking change

Proposed change

Improve logging panel:

  • fall back to reading source path to extract integration if generic logger is used
  • show in overview if it's a custom component
  • show in detailed view if it's a custom component
  • don't show a link to the documentation if the custom component links to the HA website as that is never correct, we don't ship custom components.

image

Screenshot 2021-04-13 at 17 47 07

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Comment thread src/panels/config/logs/dialog-system-log-detail.ts Outdated
Comment thread src/translations/en.json Outdated
Comment thread src/panels/config/logs/system-log-card.ts Outdated
Comment thread src/translations/en.json Outdated
@spacegaier
Copy link
Copy Markdown
Member

To make the line in the log details popup stand out more ("... originated from custom integration..."), we could in front of it add the same icon that will be used in PR #8911 as the custom integration indicator.

Co-authored-by: Joakim Sørensen <joasoe@gmail.com>
@balloob
Copy link
Copy Markdown
Member Author

balloob commented Apr 14, 2021

I don't think that it needs to stand-out more on the overview page, it's just something that needs to standout when you open the details. So I will add the icon to the overview page.

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Apr 14, 2021

image

@balloob balloob mentioned this pull request Apr 14, 2021
9 tasks
@balloob balloob merged commit b8bb0c0 into dev Apr 14, 2021
@balloob balloob deleted the logs-custom-component branch April 14, 2021 18:59
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants