Skip to content

Show config entry state on card#8911

Merged
bramkragten merged 17 commits intodevfrom
guard-manifests
Apr 16, 2021
Merged

Show config entry state on card#8911
bramkragten merged 17 commits intodevfrom
guard-manifests

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 13, 2021

Breaking change

Proposed change

The typing of manifests was incorrect, causing occasional exceptions when loading the integrations page. This makes the integration cards handle no manifest. We will only load the whole menu when manifest is loaded, this makes initial render also faster.

Also adds icons to the integration card when it's a custom component or relies on the cloud.

Two days later

I've redesigned the whole integration card together with Bram.

Screenshot.2021-04-15.at.16.28.59.mp4
Old screenshots

Screenshot 2021-04-13 at 15 59 56

Not loaded

Screenshot 2021-04-13 at 16 38 14

Retry setup

Screenshot 2021-04-13 at 16 38 28

Failed to setup

Screenshot 2021-04-13 at 16 38 50

Failed to unload

Screenshot 2021-04-13 at 16 39 16

Not loaded

Screenshot 2021-04-13 at 16 39 29

Disabled

Screenshot 2021-04-13 at 16 39 53

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob changed the title Initialize manifests to empty dict Show config entry state on card Apr 14, 2021
Comment thread src/panels/config/integrations/ha-integration-card.ts Outdated
Comment thread src/panels/config/integrations/ha-integration-card.ts Outdated
Comment thread src/panels/config/integrations/ha-integration-card.ts Outdated
@balloob
Copy link
Copy Markdown
Member Author

balloob commented Apr 14, 2021

To do:

  • Add gallery page to show all variations
  • Show error icon when config entries grouped and there is an error

@bramkragten bramkragten merged commit 60fe48d into dev Apr 16, 2021
@bramkragten bramkragten deleted the guard-manifests branch April 16, 2021 11:17
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants