Highlight match letters#8868
Closed
donkawechico wants to merge 7 commits intodevfrom
Closed
Conversation
donkawechico
force-pushed
the
highlight-match-letters
branch
from
11aa903 to
f513703
Compare
9 tasks
bramkragten
reviewed
Apr 14, 2021
bramkragten
reviewed
Apr 14, 2021
Member
|
Btw, what does that |
donkawechico
force-pushed
the
highlight-match-letters
branch
from
f513703 to
c05e566
Compare
Contributor
Author
I forget the exact context, but I made that ages ago cuz you kept reviewing my draft PRs! 😜 I tend to do a lot of early iterating in drafts and I don't want to waste folks' time. |
donkawechico
force-pushed
the
highlight-match-letters
branch
from
c05e566 to
3163eec
Compare
bramkragten
reviewed
Apr 22, 2021
bramkragten
reviewed
Apr 22, 2021
bramkragten
reviewed
Apr 22, 2021
bramkragten
reviewed
Apr 22, 2021
donkawechico
force-pushed
the
highlight-match-letters
branch
from
d1b512e to
fdf1eae
Compare
…, but return same string array decorated
donkawechico
force-pushed
the
highlight-match-letters
branch
3 times, most recently
from
9fb8ba1 to
72a2c98
Compare
donkawechico
force-pushed
the
highlight-match-letters
branch
from
72a2c98 to
448f5d7
Compare
bramkragten
reviewed
Apr 29, 2021
| score?: number; | ||
| strings: string[]; | ||
| decoratedStrings?: Decoration[][][]; | ||
| treatArrayAsSingleString?: boolean; |
Member
There was a problem hiding this comment.
Can we move this to an options object param on FuzzyFilterSort?
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Highlight the letters found with VS Code's fuzzy sequence matching algorithm (see screenshots).
Command Items
Entity Items
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: