Refactor sequence matching to accept item rather than word array#8866
Merged
donkawechico merged 3 commits intodevfrom Apr 14, 2021
Merged
Refactor sequence matching to accept item rather than word array#8866donkawechico merged 3 commits intodevfrom
donkawechico merged 3 commits intodevfrom
Conversation
c2a001c to
a2ceb7f
Compare
…rds to filter against
a2ceb7f to
64c008f
Compare
donkawechico
commented
Apr 9, 2021
bramkragten
reviewed
Apr 13, 2021
bramkragten
reviewed
Apr 13, 2021
bramkragten
reviewed
Apr 13, 2021
| return this._renderCommandItem(item, index); | ||
| } | ||
|
|
||
| if (isEntityItem(item)) { |
Member
There was a problem hiding this comment.
This is just... we check if it is not a command item, we already know that, because we checked that above...?
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Could do, but I try to avoid X as Y as it weakens type safety.
Member
There was a problem hiding this comment.
yes, but I rather do that than to add unneeded runtime checks 😄
bramkragten
reviewed
Apr 13, 2021
bramkragten
approved these changes
Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed change
Preparation for quick-bar letter highlighting (Draft PR here: #8868). Changes the
fuzzyFilterSortmethod to accept the whole item rather than an array of filter words.This has a few benefits:
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: