Add wizards for adding and removing Z-Wave JS nodes#8174
Merged
bramkragten merged 9 commits intohome-assistant:devfrom Jan 25, 2021
Merged
Add wizards for adding and removing Z-Wave JS nodes#8174bramkragten merged 9 commits intohome-assistant:devfrom
bramkragten merged 9 commits intohome-assistant:devfrom
Conversation
12 tasks
Member
Author
|
Backend PR has been merged |
Closed
7 tasks
bramkragten
reviewed
Jan 19, 2021
src/panels/config/integrations/integration-panels/zwave_js/dialog-zwave_js-add-node.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Jan 19, 2021
src/panels/config/integrations/integration-panels/zwave_js/dialog-zwave_js-remove-node.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Jan 21, 2021
src/panels/config/integrations/integration-panels/zwave_js/dialog-zwave_js-add-node.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Jan 21, 2021
src/panels/config/integrations/integration-panels/zwave_js/dialog-zwave_js-add-node.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Jan 21, 2021
src/panels/config/integrations/integration-panels/zwave_js/dialog-zwave_js-add-node.ts
Show resolved
Hide resolved
bramkragten
reviewed
Jan 21, 2021
src/panels/config/integrations/integration-panels/zwave_js/dialog-zwave_js-add-node.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Jan 21, 2021
Comment on lines
+227
to
+230
| this.hass.callWS({ | ||
| type: "zwave_js/stop_inclusion", | ||
| entry_id: this.entry_id, | ||
| }); |
Member
There was a problem hiding this comment.
Will this cause an inclusion stopped event?
Member
Author
There was a problem hiding this comment.
If the Z-Wave controller was in inclusion mode it will trigger an inclusion stopped event, otherwise no.
Member
There was a problem hiding this comment.
So we then call unsubscribe twice?
Member
Author
There was a problem hiding this comment.
Moved the actual unsubscribe part up so we unsubscribe the listener before firing the stop_inclusion/stop_exclusion websocket command
cgarwood
force-pushed
the
zwjs_add_remove_node
branch
from
067c6a5 to
315f0d2
Compare
bramkragten
approved these changes
Jan 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds an add node and remove node wizard to the Z-Wave JS config panel.
Depends on backend PR home-assistant/core#45232
AddingNode.mp4
RemoveNode.mp4
Cancel Inclusion/Cancel Exclusion buttons in the video were leftover from debugging and have been removed in the PR.
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: