Add add & remove node commands to zwave_js websocket api#45232
Merged
cgarwood merged 6 commits intohome-assistant:devfrom Jan 18, 2021
Merged
Add add & remove node commands to zwave_js websocket api#45232cgarwood merged 6 commits intohome-assistant:devfrom
cgarwood merged 6 commits intohome-assistant:devfrom
Conversation
9 tasks
MartinHjelmare
requested changes
Jan 16, 2021
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks good! I'll have another look when tests are pushed.
Member
Author
|
Pushed up most tests, still have a few more bits of the remove_node function to cover with tests but wanted to make sure these were on the right track. |
MartinHjelmare
requested changes
Jan 17, 2021
Member
|
We need to rebase too. |
1346d73 to
c00968a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This adds websocket commands to add and remove Z-Wave nodes for the Z-Wave JS integration.
Still need to write tests.
Type of change
Additional information
Checklist
black --fast homeassistant tests)