Skip to content

Add add & remove node commands to zwave_js websocket api#45232

Merged
cgarwood merged 6 commits intohome-assistant:devfrom
cgarwood:zwjs_ws_add_node
Jan 18, 2021
Merged

Add add & remove node commands to zwave_js websocket api#45232
cgarwood merged 6 commits intohome-assistant:devfrom
cgarwood:zwjs_ws_add_node

Conversation

@cgarwood
Copy link
Copy Markdown
Member

@cgarwood cgarwood commented Jan 16, 2021

Proposed change

This adds websocket commands to add and remove Z-Wave nodes for the Z-Wave JS integration.

Still need to write tests.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll have another look when tests are pushed.

@cgarwood
Copy link
Copy Markdown
Member Author

Pushed up most tests, still have a few more bits of the remove_node function to cover with tests but wanted to make sure these were on the right track.

@MartinHjelmare
Copy link
Copy Markdown
Member

We need to rebase too.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@cgarwood cgarwood merged commit 8de0b7b into home-assistant:dev Jan 18, 2021
@cgarwood cgarwood deleted the zwjs_ws_add_node branch January 18, 2021 15:13
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants