Skip to content

Adjust person / presence detection texts#8117

Merged
spacegaier merged 1 commit intohome-assistant:devfrom
spacegaier:issue-7667
Jan 13, 2021
Merged

Adjust person / presence detection texts#8117
spacegaier merged 1 commit intohome-assistant:devfrom
spacegaier:issue-7667

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

The current wording is weird. This is one potential proposal. For more details see discussion in linked issue.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

"messages": {
"was_away": "was away",
"was_at_state": "was at {state}",
"was_away": "was detected away",
Copy link
Copy Markdown
Member Author

@spacegaier spacegaier Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one sounds slightly weird, but nicely short. Alternatives:
"was detected being away"
"was detected outside home"

@spacegaier spacegaier merged commit 95fd8de into home-assistant:dev Jan 13, 2021
@spacegaier spacegaier deleted the issue-7667 branch January 13, 2021 19:13
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

device_trackers show 'incorrect' state in logbook

3 participants