Skip to content

Disable counter buttons if entity is unavailable #8084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 4 commits into from
Jan 4, 2021
Merged

Disable counter buttons if entity is unavailable #8084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffb872d
Disable counter buttons if entity is unavailable
spacegaier Jan 4, 2021
8e241a8
Removed blank
spacegaier Jan 4, 2021
8225a7d
Backout accidental commit
spacegaier Jan 4, 2021
f752b50
Changes from review
spacegaier Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/dialogs/more-info/controls/more-info-counter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
TemplateResult,
} from "lit-element";
import { HomeAssistant } from "../../../types";
import { UNAVAILABLE_STATES } from "../../../data/entity";

@customElement("more-info-counter")
class MoreInfoCounter extends LitElement {
Expand All @@ -22,21 +23,29 @@ class MoreInfoCounter extends LitElement {
return html``;
}

const disabled = UNAVAILABLE_STATES.includes(this.stateObj!.state);

return html`
<div class="actions">
<mwc-button
.action="${"increment"}"
@click="${this._handleActionClick}"
@click=${this._handleActionClick}
.disabled=${disabled}
>
${this.hass!.localize("ui.card.counter.actions.increment")}
</mwc-button>
<mwc-button
.action="${"decrement"}"
@click="${this._handleActionClick}"
@click=${this._handleActionClick}
.disabled=${disabled}
>
${this.hass!.localize("ui.card.counter.actions.decrement")}
</mwc-button>
<mwc-button .action="${"reset"}" @click="${this._handleActionClick}">
<mwc-button
.action="${"reset"}"
@click=${this._handleActionClick}
.disabled=${disabled}
>
${this.hass!.localize("ui.card.counter.actions.reset")}
</mwc-button>
</div>
Expand All @@ -53,8 +62,7 @@ class MoreInfoCounter extends LitElement {
static get styles(): CSSResult {
return css`
.actions {
margin: 0;
padding-top: 20px;
margin: 8px 0;
display: flex;
flex-wrap: wrap;
justify-content: center;
Expand Down
2 changes: 1 addition & 1 deletion src/dialogs/more-info/controls/more-info-person.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class MoreInfoPerson extends LitElement {
justify-content: space-between;
}
.actions {
margin: 36px 0 8px 0;
margin: 8px 0;
text-align: right;
}
ha-map {
Expand Down
3 changes: 1 addition & 2 deletions src/dialogs/more-info/controls/more-info-timer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ class MoreInfoTimer extends LitElement {
static get styles(): CSSResult {
return css`
.actions {
margin: 0;
padding-top: 20px;
margin: 8px 0;
display: flex;
flex-wrap: wrap;
justify-content: center;
Expand Down