Skip to content

Disable counter buttons if entity is unavailable#8084

Merged
bramkragten merged 4 commits intohome-assistant:devfrom
spacegaier:issue-8063
Jan 4, 2021
Merged

Disable counter buttons if entity is unavailable#8084
bramkragten merged 4 commits intohome-assistant:devfrom
spacegaier:issue-8063

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Disable the buttons if entity is not available.

Also reduced some margins for more-info elements. Given that the state display already adds 16px at the bottom before the more-info section starts and the mdc-dialog-content-box also already has 20px padding, there is more then enough negative space already.

image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 0208b50 into home-assistant:dev Jan 4, 2021
@spacegaier spacegaier deleted the issue-8063 branch January 5, 2021 11:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Counter more-info dialog shows controls when entity is unavailable

3 participants