Do not render "No Area" in device table to reduce clutter#7986
Merged
bramkragten merged 1 commit intohome-assistant:devfrom Dec 29, 2020
Merged
Do not render "No Area" in device table to reduce clutter#7986bramkragten merged 1 commit intohome-assistant:devfrom
bramkragten merged 1 commit intohome-assistant:devfrom
Conversation
bramkragten
approved these changes
Dec 29, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on PR #7985 for sorting logic.
Breaking change
Proposed change
Currently the UI fills the "Area" column of the devices overview with "No Area" if none was assigned. That makes it very hard to find the ones that you still have to assign. Plus in the entity overview we do not do that either.
This PR removes the auto-filled "No area". Once the above mentioned prerequisite PR has been merged, having the area value as "undefined" is no longer an issue for sorting as well.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: