Skip to content

Do not render "No Area" in device table to reduce clutter#7986

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:no-no-area
Dec 29, 2020
Merged

Do not render "No Area" in device table to reduce clutter#7986
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:no-no-area

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Depends on PR #7985 for sorting logic.

Breaking change

Proposed change

Currently the UI fills the "Area" column of the devices overview with "No Area" if none was assigned. That makes it very hard to find the ones that you still have to assign. Plus in the entity overview we do not do that either.

This PR removes the auto-filled "No area". Once the above mentioned prerequisite PR has been merged, having the area value as "undefined" is no longer an issue for sorting as well.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit ef3bc3e into home-assistant:dev Dec 29, 2020
@bramkragten bramkragten mentioned this pull request Dec 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2020
@spacegaier spacegaier deleted the no-no-area branch January 5, 2021 11:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants