Skip to content

Handle sorting with "undefined" (move always to bottom)#7985

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:issue-7984
Dec 29, 2020
Merged

Handle sorting with "undefined" (move always to bottom)#7985
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:issue-7984

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Ensure sorting does not break if a column value is undefined. Those entries are now always sorted to the bottom regardless of whether we are in asc or desc mode. Previously the sorting did not work since we e.g. compared string with NaN.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 371ad89 into home-assistant:dev Dec 29, 2020
@bramkragten bramkragten mentioned this pull request Dec 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2020
@spacegaier spacegaier deleted the issue-7984 branch January 5, 2021 11:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sorting by area is mixed up, not working

3 participants