Skip to content

Catch navigator.clipboard errors#7942

Merged
bramkragten merged 6 commits intohome-assistant:devfrom
spacegaier:follow-up-7790
Jan 4, 2021
Merged

Catch navigator.clipboard errors#7942
bramkragten merged 6 commits intohome-assistant:devfrom
spacegaier:follow-up-7790

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Follow-up based on this comment: #7900 (comment)

Cannot really test, since my dev instance is not using HTTPS => navigator.clipboard is undefined, so legacy coding is always used.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

spacegaier and others added 2 commits January 4, 2021 11:11
@spacegaier spacegaier marked this pull request as draft January 4, 2021 10:26
@spacegaier spacegaier marked this pull request as ready for review January 4, 2021 10:44
@spacegaier spacegaier requested a review from bramkragten January 4, 2021 10:44
@bramkragten bramkragten merged commit 05057ad into home-assistant:dev Jan 4, 2021
@spacegaier spacegaier deleted the follow-up-7790 branch January 5, 2021 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants