Add copy YAML (automation & script) fallback without navigator.clipboard#7900
Merged
bramkragten merged 3 commits intohome-assistant:devfrom Dec 10, 2020
Merged
Add copy YAML (automation & script) fallback without navigator.clipboard#7900bramkragten merged 3 commits intohome-assistant:devfrom
navigator.clipboard#7900bramkragten merged 3 commits intohome-assistant:devfrom
Conversation
spacegaier
changed the title
navigator.clipboardnavigator.clipboard
bramkragten
reviewed
Dec 4, 2020
bramkragten
reviewed
Dec 7, 2020
bramkragten
approved these changes
Dec 8, 2020
bramkragten
reviewed
Dec 8, 2020
| document.execCommand("copy"); | ||
| document.body.removeChild(el); | ||
| if (navigator.clipboard) { | ||
| navigator.clipboard.writeText(str); |
Member
There was a problem hiding this comment.
This returns a promise, we should await it and catch any errors so we can fallback
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
The
navigator.clipboardapproach will only work with HTTPS. Add fallback for other use cases.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: