Skip to content

Fix spinner and 'Configuration' text in navigation commands#7753

Merged
donkawechico merged 1 commit intodevfrom
fix_navigation_text_and_spinner
Nov 21, 2020
Merged

Fix spinner and 'Configuration' text in navigation commands#7753
donkawechico merged 1 commit intodevfrom
fix_navigation_text_and_spinner

Conversation

@donkawechico
Copy link
Copy Markdown
Contributor

@donkawechico donkawechico commented Nov 20, 2020

Proposed change

This PR:

  1. Removes the "Navigate to ____ Configuration" dynamic translation entirely (there are way too many items with "Configuration" at the end)
  2. Fixes a regression from Minor visual QB command tweaks #7590 that stopped the loading spinner from being rendered.

Old

New

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@donkawechico donkawechico force-pushed the fix_navigation_text_and_spinner branch from b9ead0d to aafdb0d Compare November 20, 2020 22:26
@donkawechico donkawechico modified the milestone: 0.118.0 Nov 20, 2020
@donkawechico donkawechico changed the title Remove extra 'Configuration' text in navigation commands Remove extra 'Configuration' text in navigation commands. Fix spinner. Nov 20, 2020
@donkawechico donkawechico changed the title Remove extra 'Configuration' text in navigation commands. Fix spinner. Fix spinner and 'Configuration' text in navigation commands Nov 20, 2020
@bramkragten bramkragten added this to the 0.118.2 milestone Nov 21, 2020
@donkawechico donkawechico force-pushed the fix_navigation_text_and_spinner branch from aafdb0d to 24bf56c Compare November 21, 2020 16:20
@donkawechico donkawechico merged commit 17d227b into dev Nov 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix_navigation_text_and_spinner branch November 21, 2020 16:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2020
@donkawechico donkawechico modified the milestones: 0.118.2, 0.118.3, 0.118.4 Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants