Skip to content

Minor visual QB command tweaks#7590

Merged
bramkragten merged 5 commits intohome-assistant:devfrom
spacegaier:qb-command-tweaks
Nov 10, 2020
Merged

Minor visual QB command tweaks#7590
bramkragten merged 5 commits intohome-assistant:devfrom
spacegaier:qb-command-tweaks

Conversation

@spacegaier
Copy link
Member

@spacegaier spacegaier commented Nov 3, 2020

Breaking change

Proposed change

Fixes two small issues:

  1. The command icon was not properly colored in
  2. The command mode list used a different icon type, which looked inconsistent when compared to the entity mode (icons in different position compared to entity mode = not under the icon of the search input)

@donkawechico Please check if fine with you, since your "baby"

Before:
grafik

After (command mode):
image

After (entity mode):
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Member

The icon seems so close to the text, is that according to the official specs? 🤔

@spacegaier
Copy link
Member Author

The icon seems so close to the text, is that according to the official specs? 🤔

You are correct. I will need to adjust that and add a few more pixels in there.

@spacegaier
Copy link
Member Author

spacegaier commented Nov 9, 2020

I added the missing 16px margin as defined by the material specs: https://material.io/components/lists#specs

Screenshots are updated in first post.

@bramkragten bramkragten merged commit b7bcf97 into home-assistant:dev Nov 10, 2020
@spacegaier spacegaier deleted the qb-command-tweaks branch November 10, 2020 11:13
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants