Skip to content

Add state-info ellipsis + fix height#7740

Merged
bramkragten merged 2 commits intohome-assistant:devfrom
spacegaier:state-info-fixes
Nov 26, 2020
Merged

Add state-info ellipsis + fix height#7740
bramkragten merged 2 commits intohome-assistant:devfrom
spacegaier:state-info-fixes

Conversation

@spacegaier
Copy link
Member

@spacegaier spacegaier commented Nov 20, 2020

Breaking change

Proposed change

  1. Add ellipsis to state name
  2. Remove fixed height to achieve the more compact design of name and relative-time we had before

=> Does it perhaps even make sense to use a hover-maquee for the name or is the intended solution to use the existing double click on the dialog header to go to a wider dialog if you need the whole name? Or add a tooltip with the whole name?

Before:
image

After:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@Misiu
Copy link
Contributor

Misiu commented Nov 20, 2020

@spacegaier I like the idea to make dialog wider by double-clicking on the dialog header (like here: #7492).
The whole name will be visible, but there is one extra benefit: the graph will be wider and more readable.
Just my 2¢.

@spacegaier
Copy link
Member Author

@Misiu That option already exists today. My wording above probably was a bit misleading.

@bramkragten bramkragten merged commit 6020890 into home-assistant:dev Nov 26, 2020
@bramkragten bramkragten mentioned this pull request Nov 26, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants