Skip to content

Move data_entry_flow_progressed event subscriber#7700

Merged
bramkragten merged 2 commits intodevfrom
move-eventlistener
Nov 17, 2020
Merged

Move data_entry_flow_progressed event subscriber#7700
bramkragten merged 2 commits intodevfrom
move-eventlistener

Conversation

@ludeeus
Copy link
Member

@ludeeus ludeeus commented Nov 15, 2020

Breaking change

Proposed change

Moves the data_entry_flow_progressed event subscriber form both the "external" and the "progress" steps to the parrent element.

When they where in their sub-elements , the subscriber attached too late which resulted in not responding to the data_entry_flow_progressed emitted by the backend.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 8fd1f35 into dev Nov 17, 2020
@bramkragten bramkragten deleted the move-eventlistener branch November 17, 2020 14:12
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants