Skip to content

Add show progress to ozw config flow#43310

Merged
MartinHjelmare merged 6 commits intodevfrom
use-info-step-ozw-flow
Nov 30, 2020
Merged

Add show progress to ozw config flow#43310
MartinHjelmare merged 6 commits intodevfrom
use-info-step-ozw-flow

Conversation

@MartinHjelmare
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare commented Nov 17, 2020

Breaking change

Proposed change

  • Add a show progress prompt that informs the user that the add-on install has started and will take some time.

Todo

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @cgarwood, @marcelveldt, mind taking a look at this pull request as its been labeled with an integration (ozw) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare
Copy link
Copy Markdown
Member Author

I'll test this with the new frontend and then merge.

@MartinHjelmare MartinHjelmare marked this pull request as ready for review November 30, 2020 17:58
@MartinHjelmare
Copy link
Copy Markdown
Member Author

Tested and working.

@MartinHjelmare MartinHjelmare merged commit 3f5d7e8 into dev Nov 30, 2020
@MartinHjelmare MartinHjelmare deleted the use-info-step-ozw-flow branch November 30, 2020 17:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants