Skip to content

Prevent slider pin from being cut-off at the top #7572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spacegaier wants to merge 1 commit into from
Closed

Prevent slider pin from being cut-off at the top #7572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/dialogs/more-info/controls/more-info-cover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ class MoreInfoCover extends LocalizeMixin(PolymerElement) {
.current_position,
.tilt {
max-height: 0px;
overflow: hidden;
Comment on lines 23 to -24
Copy link
Copy Markdown
Member

@bramkragten bramkragten Nov 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it will not be hidden when it should?

Copy link
Copy Markdown
Member Author

@spacegaier spacegaier Nov 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. I just now had my cover pretend that it cannot tilt, and then this simplistic fix does not work.

Probably better to somehow fix that then inside the ha-slider. But snce I am not a CSS wiz, I guess that might be beyond my capabilities.

}

.has-set_position .current_position,
Expand Down
1 change: 0 additions & 1 deletion src/dialogs/more-info/controls/more-info-light.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,6 @@ class MoreInfoLight extends LitElement {
.content > * {
width: 100%;
max-height: 84px;
overflow: hidden;
}

.color_temp {
Expand Down