Skip to content

Prevent slider pin from being cut-off at the top#7572

Closed
spacegaier wants to merge 1 commit intohome-assistant:devfrom
spacegaier:pin-cut-off-fix
Closed

Prevent slider pin from being cut-off at the top#7572
spacegaier wants to merge 1 commit intohome-assistant:devfrom
spacegaier:pin-cut-off-fix

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Prevent sliders pins in more-info-light and more-info-cover from being cut of by the state-badge above.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Comment on lines 23 to -24
max-height: 0px;
overflow: hidden;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it will not be hidden when it should?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. I just now had my cover pretend that it cannot tilt, and then this simplistic fix does not work.

Probably better to somehow fix that then inside the ha-slider. But snce I am not a CSS wiz, I guess that might be beyond my capabilities.

@bramkragten bramkragten self-assigned this Nov 9, 2020
@bramkragten
Copy link
Copy Markdown
Member

#7651

@spacegaier spacegaier deleted the pin-cut-off-fix branch November 11, 2020 14:37
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slider value label cut off

3 participants