Skip to content

Dark mode header color#7514

Merged
bramkragten merged 25 commits intohome-assistant:devfrom
maykar:dark-theme-header-color
Nov 1, 2020
Merged

Dark mode header color#7514
bramkragten merged 25 commits intohome-assistant:devfrom
maykar:dark-theme-header-color

Conversation

@maykar
Copy link
Contributor

@maykar maykar commented Oct 28, 2020

Proposed change

This changes header background color in dark mode to use a darkened version of the primary color. This will help differentiate it from cards, especially in panel mode as right now they are the same color.

This is related to a conversation from this PR #7465 and is proposed as an alternate solution.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

darkheader

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

maykar and others added 2 commits October 28, 2020 16:39
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Copy link
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge after comments!

@bramkragten bramkragten merged commit 3b91343 into home-assistant:dev Nov 1, 2020
@KTibow
Copy link
Contributor

KTibow commented Nov 2, 2020

Have some questions about it:

  • Will we be able to override it with app-header-background-color?
  • (unrelated) Can we specify a custom theme as a dark theme, and base it off of the dark theme defaults using dark?

@bramkragten bramkragten mentioned this pull request Nov 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants