Dark mode header color#7514
Merged
bramkragten merged 25 commits intohome-assistant:devfrom Nov 1, 2020
maykar:dark-theme-header-color
Merged
Dark mode header color#7514bramkragten merged 25 commits intohome-assistant:devfrom maykar:dark-theme-header-color
bramkragten merged 25 commits intohome-assistant:devfrom
maykar:dark-theme-header-color
Conversation
bramkragten
reviewed
Oct 28, 2020
bramkragten
reviewed
Oct 28, 2020
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
9 tasks
bramkragten
reviewed
Oct 29, 2020
bramkragten
reviewed
Oct 29, 2020
bramkragten
reviewed
Oct 29, 2020
bramkragten
approved these changes
Oct 29, 2020
Member
bramkragten
left a comment
There was a problem hiding this comment.
OK to merge after comments!
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
reviewed
Oct 29, 2020
bramkragten
reviewed
Oct 29, 2020
bramkragten
reviewed
Oct 30, 2020
bramkragten
reviewed
Oct 30, 2020
bramkragten
approved these changes
Nov 1, 2020
Contributor
|
Have some questions about it:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This changes header background color in dark mode to use a darkened version of the primary color. This will help differentiate it from cards, especially in panel mode as right now they are the same color.
This is related to a conversation from this PR #7465 and is proposed as an alternate solution.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: