Skip to content

Ensure visual gap in dark panel mode between header and content #7465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spacegaier wants to merge 2 commits into from
Closed

Ensure visual gap in dark panel mode between header and content #7465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65cd480
Ensure visual gap in dark panel mode between header and content
spacegaier Oct 23, 2020
c313efa
Adjust minimum height with the gap (prevent scrollbars in chrome)
spacegaier Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/panels/lovelace/hui-root.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,7 +831,8 @@ class HUIRoot extends LitElement {
color: var(--error-color);
}
#view {
min-height: calc(100vh - var(--header-height));
/** -8 to account for the gap between content and app header */
min-height: calc(100vh - var(--header-height) - 8);
/**
* Since we only set min-height, if child nodes need percentage
* heights they must use absolute positioning so we need relative
Expand Down
2 changes: 2 additions & 0 deletions src/panels/lovelace/views/hui-panel-view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,8 @@ export class PanelView extends LitElement implements LovelaceViewElement {
:host {
display: block;
height: 100%;
/** Ensure gap between content and app header for visual separation */
margin-top: 8px;
}

mwc-fab {
Expand Down