Fix quick bar dark mode contrast, filter returning all items, no primary text#7430
Merged
bramkragten merged 6 commits intodevfrom Oct 22, 2020
Merged
Fix quick bar dark mode contrast, filter returning all items, no primary text#7430bramkragten merged 6 commits intodevfrom
bramkragten merged 6 commits intodevfrom
Conversation
9 tasks
9 tasks
Contributor
Author
bramkragten
reviewed
Oct 22, 2020
Member
|
The contrast being too low in dark mode is not a quick bar only issue, but for every |
bramkragten
reviewed
Oct 22, 2020
bramkragten
reviewed
Oct 22, 2020
a213b0f to
d5c4d73
Compare
223a37a to
b807957
Compare
b807957 to
815e308
Compare
bramkragten
reviewed
Oct 22, 2020
bramkragten
reviewed
Oct 22, 2020
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
reviewed
Oct 22, 2020
bramkragten
approved these changes
Oct 22, 2020
bramkragten
added a commit
that referenced
this pull request
Oct 22, 2020
…ary text (#7430) Co-authored-by: Bram Kragten <mail@bramkragten.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed change
Fixes a few regressions caused by #7359:
...and an unrelated but minor bug discovered after beta release:
3. List item primary text showing nothing when friendly name is empty string
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: