Skip to content

Fix no primary text in quick bar item if friendly name is empty string#7429

Closed
donkawechico wants to merge 1 commit intodevfrom
quick-bar-show-entity-id
Closed

Fix no primary text in quick bar item if friendly name is empty string#7429
donkawechico wants to merge 1 commit intodevfrom
quick-bar-show-entity-id

Conversation

@donkawechico
Copy link
Contributor

@donkawechico donkawechico commented Oct 21, 2020

Proposed change

Use entity id for primary text if computeStateDomain(entity) returns an empty string.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@donkawechico donkawechico force-pushed the quick-bar-show-entity-id branch from 8e04182 to b3c945d Compare October 21, 2020 23:27
@donkawechico
Copy link
Contributor Author

donkawechico commented Oct 22, 2020

Closing this and putting the fix into this pr: #7430

@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants