Skip to content

Remove debounce from quick bar until "select all" bug is resolved #7425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
donkawechico wants to merge 1 commit into from
Closed

Remove debounce from quick bar until "select all" bug is resolved #7425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/dialogs/quick-bar/ha-quick-bar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import {
fuzzyFilterSort,
ScorableTextItem,
} from "../../common/string/filter/sequence-matching";
import { debounce } from "../../common/util/debounce";
import "../../components/ha-circular-progress";
import "../../components/ha-dialog";
import "../../components/ha-header-bar";
Expand Down Expand Up @@ -237,10 +236,10 @@ export class QuickBar extends LitElement {

if (newFilter.startsWith(">")) {
this._commandMode = true;
this._debouncedSetFilter(newFilter.substring(1));
this._filter = newFilter.substring(1);
} else {
this._commandMode = false;
this._debouncedSetFilter(newFilter);
this._filter = newFilter;
}

if (oldCommandMode !== this._commandMode) {
Expand All @@ -249,10 +248,6 @@ export class QuickBar extends LitElement {
}
}

private _debouncedSetFilter = debounce((filter: string) => {
this._filter = filter;
}, 100);

private _setFocusFirstListItem() {
// @ts-ignore
this._getItemAtIndex(0)?.rippleHandlers.startFocus();
Expand Down