Skip to content

Remove debounce from quick bar until "select all" bug is resolved#7425

Closed
donkawechico wants to merge 1 commit intodevfrom
quick-bar-fix-select-all
Closed

Remove debounce from quick bar until "select all" bug is resolved#7425
donkawechico wants to merge 1 commit intodevfrom
quick-bar-fix-select-all

Conversation

@donkawechico
Copy link
Contributor

@donkawechico donkawechico commented Oct 21, 2020

Proposed change

Remove the filter debouncing from quick bar (for now).

In its current form, debouncing the quick bar filter causes a bug when a single change would cause -- simultaneously -- a switch of command mode AND a new filter string (e.g., select all text in command mode -> type "L")

I suspect what's happening is this:

  1. User types ">reload". (this._filter is now "reload")
  2. User selects all and replaces it with "L"
  3. First, the change in filter fires off a task to change this._filter to "L" in 100ms
  4. Second, the change of command mode fires off a task to change the filter to "reload" in 100ms.
  5. Because it's debounced, the 2nd change wins the race and "L" is lost.

I'm not sure what the best solution is but for now, removing the debounce fixes the issue.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Member

#7426

@zsarnett zsarnett closed this Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants