Remove debounce from quick bar until "select all" bug is resolved#7425
Closed
donkawechico wants to merge 1 commit intodevfrom
Closed
Remove debounce from quick bar until "select all" bug is resolved#7425donkawechico wants to merge 1 commit intodevfrom
donkawechico wants to merge 1 commit intodevfrom
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Remove the filter debouncing from quick bar (for now).
In its current form, debouncing the quick bar filter causes a bug when a single change would cause -- simultaneously -- a switch of command mode AND a new filter string (e.g., select all text in command mode -> type "L")
I suspect what's happening is this:
this._filteris now "reload")this._filterto "L" in 100msI'm not sure what the best solution is but for now, removing the debounce fixes the issue.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: