Skip to content

Improve performance of quick bar #7359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 12 commits into from
Oct 21, 2020
Merged

Improve performance of quick bar #7359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2e3193f
Improve performance of quick bar
bramkragten Oct 16, 2020
b04c6b1
Fix keyboard nav
bramkragten Oct 16, 2020
3f53143
remove debounce
bramkragten Oct 16, 2020
aee4210
Fix selected
bramkragten Oct 20, 2020
b150741
Set items after animation finished
bramkragten Oct 20, 2020
fd41b10
Fix styling of virtualized list
bramkragten Oct 20, 2020
21522b6
Fix issue with first list item not being selected
donkawechico Oct 20, 2020
ed26ce0
Merge branch 'quick-bar-speed' of https://github.com/home-assistant/h…
bramkragten Oct 21, 2020
e8f8a14
Tweaks
bramkragten Oct 21, 2020
31441f2
Add debounce back
bramkragten Oct 21, 2020
7e0ce6f
Organize imports (for Zack)
bramkragten Oct 21, 2020
4f09512
Update ha-quick-bar.ts
bramkragten Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/common/search/search-input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,18 +51,14 @@ class SearchInput extends LitElement {
@value-changed=${this._filterInputChanged}
.noLabelFloat=${this.noLabelFloat}
>
<ha-svg-icon
.path=${mdiMagnify}
slot="prefix"
class="prefix"
></ha-svg-icon>
<slot name="prefix" slot="prefix">
<ha-svg-icon class="prefix" .path=${mdiMagnify}></ha-svg-icon>
</slot>
${this.filter &&
html`
<mwc-icon-button
slot="suffix"
class="suffix"
@click=${this._clearSearch}
alt="Clear"
title="Clear"
>
<ha-svg-icon .path=${mdiClose}></ha-svg-icon>
Expand Down
1 change: 1 addition & 0 deletions src/common/string/filter/sequence-matching.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export const fuzzyFilterSort: FuzzyFilterSort = (filter, items) => {
: fuzzySequentialMatch(filter, item.text);
return item;
})
.filter((item) => item.score === undefined || item.score > 0)
Copy link
Copy Markdown
Contributor

@donkawechico donkawechico Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in here? This would return all invalid items.

Copy link
Copy Markdown
Contributor

@donkawechico donkawechico Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed here: #7430

Copy link
Copy Markdown
Member Author

@bramkragten bramkragten Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's your code 😅

Copy link
Copy Markdown
Contributor

@donkawechico donkawechico Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, it is? 😆 Man I need to learn to read git history better. Sigh...

.sort(({ score: scoreA = 0 }, { score: scoreB = 0 }) =>
scoreA > scoreB ? -1 : scoreA < scoreB ? 1 : 0
);
Expand Down
Loading