Skip to content

Add media player to cast app#7160

Merged
bramkragten merged 4 commits intodevfrom
add-media-player-to-cast
Sep 30, 2020
Merged

Add media player to cast app#7160
bramkragten merged 4 commits intodevfrom
add-media-player-to-cast

Conversation

@bramkragten
Copy link
Member

Proposed change

Adds a media player to our cast app

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

CAST_NS,
// @ts-ignore
(ev: ReceivedMessage<HassMessage>) => {
if (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some comments what we're doing here

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@hunterjm
Copy link
Member

You’re the man @bramkragten!

bramkragten and others added 2 commits September 30, 2020 09:30
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@bramkragten bramkragten merged commit d2e9e22 into dev Sep 30, 2020
@bramkragten bramkragten deleted the add-media-player-to-cast branch September 30, 2020 08:24
@bramkragten bramkragten mentioned this pull request Sep 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants