Skip to content

Use custom app to play camera stream using Google Assistant#40750

Merged
balloob merged 3 commits intodevfrom
use-homeassistant-cast-app-for-camera-stream-ga
Sep 30, 2020
Merged

Use custom app to play camera stream using Google Assistant#40750
balloob merged 3 commits intodevfrom
use-homeassistant-cast-app-for-camera-stream-ga

Conversation

@bramkragten
Copy link
Member

@bramkragten bramkragten commented Sep 29, 2020

Proposed change

Use the home assistant cast app to play camera streams from google assistant, so correctly set the format.
Needs home-assistant/frontend#7160

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @emontnemery, mind taking a look at this pull request as its been labeled with an integration (cast) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob modified the milestones: 0.115.5, 0.115.6 Sep 30, 2020
@balloob balloob merged commit c6f3352 into dev Sep 30, 2020
@balloob balloob deleted the use-homeassistant-cast-app-for-camera-stream-ga branch September 30, 2020 08:34
@balloob balloob mentioned this pull request Sep 30, 2020
@ioannispelelis
Copy link

Hello, is this expected that this function requires Nabu Casa and cannot work if we have made a manual integration with google home or should i open a bug?

@bramkragten
Copy link
Member Author

Don't add comments to closed PR's and especially not the same comment both on a closed PR and on a closed issue.

@ioannispelelis
Copy link

Don't add comments to closed PR's and especially not the same comment both on a closed PR and on a closed issue.

Sorry i first saw this PR and after the issue. Shall i open a new issue or can i continue the discussion on the existing issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Playing camera stream using google assistant is broken in 0.115

5 participants