Use custom app to play camera stream using Google Assistant#40750
Merged
Use custom app to play camera stream using Google Assistant#40750
Conversation
|
Hey there @emontnemery, mind taking a look at this pull request as its been labeled with an integration ( |
balloob
approved these changes
Sep 30, 2020
balloob
pushed a commit
that referenced
this pull request
Sep 30, 2020
Merged
Bre77
pushed a commit
to Bre77/core
that referenced
this pull request
Oct 1, 2020
|
Hello, is this expected that this function requires Nabu Casa and cannot work if we have made a manual integration with google home or should i open a bug? |
Member
Author
|
Don't add comments to closed PR's and especially not the same comment both on a closed PR and on a closed issue. |
Sorry i first saw this PR and after the issue. Shall i open a new issue or can i continue the discussion on the existing issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Use the home assistant cast app to play camera streams from google assistant, so correctly set the format.
Needs home-assistant/frontend#7160
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: