Skip to content

Fix eslint import extension#682

Merged
balloob merged 3 commits intomasterfrom
fix-eslint-import-extension
Nov 25, 2017
Merged

Fix eslint import extension#682
balloob merged 3 commits intomasterfrom
fix-eslint-import-extension

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Nov 25, 2017

Extracted ESLint fixes from #680. Also renames computeDomain to computeStateDomain and extracts computeDomain as one that takes in an entityId.

@@ -0,0 +1,12 @@
import computeStateDomain from '../../../js/common/util/compute_state_domain.js';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../../js/common/util/compute_state_domain.js' import/no-unresolved
Unexpected use of file extension "js" for "../../../js/common/util/compute_state_domain.js" import/extensions

import computeStateDisplay from './common/util/compute_state_display.js';
import formatDate from './common/util/format_date.js';
import formatDateTime from './common/util/format_date_time.js';
import formatTime from './common/util/format_time.js';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './common/util/format_time.js' import/no-unresolved
Unexpected use of file extension "js" for "./common/util/format_time.js" import/extensions

import computeStateDomain from './common/util/compute_state_domain.js';
import computeStateDisplay from './common/util/compute_state_display.js';
import formatDate from './common/util/format_date.js';
import formatDateTime from './common/util/format_date_time.js';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './common/util/format_date_time.js' import/no-unresolved
Unexpected use of file extension "js" for "./common/util/format_date_time.js" import/extensions

import attributeClassNames from './common/util/attribute_class_names.js';
import computeStateDomain from './common/util/compute_state_domain.js';
import computeStateDisplay from './common/util/compute_state_display.js';
import formatDate from './common/util/format_date.js';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './common/util/format_date.js' import/no-unresolved
Unexpected use of file extension "js" for "./common/util/format_date.js" import/extensions

import formatTime from './common/util/format_time';
import attributeClassNames from './common/util/attribute_class_names.js';
import computeStateDomain from './common/util/compute_state_domain.js';
import computeStateDisplay from './common/util/compute_state_display.js';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './common/util/compute_state_display.js' import/no-unresolved
Unexpected use of file extension "js" for "./common/util/compute_state_display.js" import/extensions

import formatTime from './format_time';
import computeStateDomain from './compute_state_domain.js';
import formatDateTime from './format_date_time.js';
import formatDate from './format_date.js';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './format_date.js' import/no-unresolved
Unexpected use of file extension "js" for "./format_date.js" import/extensions

import formatDate from './format_date';
import formatTime from './format_time';
import computeStateDomain from './compute_state_domain.js';
import formatDateTime from './format_date_time.js';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './format_date_time.js' import/no-unresolved
Unexpected use of file extension "js" for "./format_date_time.js" import/extensions

import formatDateTime from './format_date_time';
import formatDate from './format_date';
import formatTime from './format_time';
import computeStateDomain from './compute_state_domain.js';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './compute_state_domain.js' import/no-unresolved
Unexpected use of file extension "js" for "./compute_state_domain.js" import/extensions

@@ -1,5 +1,5 @@
import { h, Component } from 'preact';
import { onChangeEvent } from '../../util/event';
import { onChangeEvent } from '../../util/event.js';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../util/event.js' import/no-unresolved
Unexpected use of file extension "js" for "../../util/event.js" import/extensions

import { h, Component } from 'preact';

import ActionRow from './action_row';
import ActionRow from './action_row.js';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './action_row.js' import/no-unresolved
Unexpected use of file extension "js" for "./action_row.js" import/extensions

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Nov 25, 2017

sigh, forgot the updated eslint config. Oh Hound, you so spammy.

@balloob balloob merged commit 2845774 into master Nov 25, 2017
@balloob balloob deleted the fix-eslint-import-extension branch November 26, 2017 00:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants