Skip to content

Expose entities for Google/Alexa#680

Merged
balloob merged 7 commits intodevfrom
add-entity-filter
Nov 6, 2018
Merged

Expose entities for Google/Alexa#680
balloob merged 7 commits intodevfrom
add-entity-filter

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Nov 25, 2017

This ports the entity filter function from Home Assistant from Python to JavaScript. We will be able to use this function to power a user interface for exposing entities for Google Assistant, Emulated Hue, Alexa (as per #679)

Implemented function on the cloud dashboard.

Requires: home-assistant/core#18216

Copy link
Copy Markdown

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.eslintrc:
.eslintrc:
	Configuration for rule "import/extensions" is invalid:
	Severity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed '"always"').

Error: .eslintrc:
at validateRuleOptions (/app/node_modules/eslint/lib/config/config-validator.js:113:15)
at Object.keys.forEach.id (/app/node_modules/eslint/lib/config/config-validator.js:153:9)
at Array.forEach ()
at validateRules (/app/node_modules/eslint/lib/config/config-validator.js:152:30)
at Object.validate (/app/node_modules/eslint/lib/config/config-validator.js:230:5)
at loadFromDisk (/app/node_modules/eslint/lib/config/config-file.js:549:19)
at Object.load (/app/node_modules/eslint/lib/config/config-file.js:592:20)
at Config.getLocalConfigHierarchy (/app/node_modules/eslint/lib/config.js:226:44)
at Config.getConfigHierarchy (/app/node_modules/eslint/lib/config.js:180:43)
at Config.getConfigVector (/app/node_modules/eslint/lib/config.js:285:21)

Copy link
Copy Markdown

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.eslintrc:
.eslintrc:
	Configuration for rule "import/extensions" is invalid:
	Severity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed '"always"').

Error: .eslintrc:
at validateRuleOptions (/app/node_modules/eslint/lib/config/config-validator.js:113:15)
at Object.keys.forEach.id (/app/node_modules/eslint/lib/config/config-validator.js:153:9)
at Array.forEach ()
at validateRules (/app/node_modules/eslint/lib/config/config-validator.js:152:30)
at Object.validate (/app/node_modules/eslint/lib/config/config-validator.js:230:5)
at loadFromDisk (/app/node_modules/eslint/lib/config/config-file.js:549:19)
at Object.load (/app/node_modules/eslint/lib/config/config-file.js:592:20)
at Config.getLocalConfigHierarchy (/app/node_modules/eslint/lib/config.js:226:44)
at Config.getConfigHierarchy (/app/node_modules/eslint/lib/config.js:180:43)
at Config.getConfigVector (/app/node_modules/eslint/lib/config.js:285:21)

@@ -0,0 +1,88 @@
import entityFilter from '../../../js/common/util/entity_filter';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing file extension for "../../../js/common/util/entity_filter" import/extensions

@home-assistant home-assistant deleted a comment from houndci-bot Nov 25, 2017
@home-assistant home-assistant deleted a comment from houndci-bot Nov 25, 2017
@home-assistant home-assistant deleted a comment from houndci-bot Nov 25, 2017
@home-assistant home-assistant deleted a comment from houndci-bot Nov 25, 2017
@andrey-git
Copy link
Copy Markdown
Contributor

I think each new function should have at least one (non test) use

@andrey-git
Copy link
Copy Markdown
Contributor

Is the lint change specific for hound or is it relevant for local eslint too?

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Nov 25, 2017

I agree that we need non-test use. Waiting for #674 and #675 to land 👍 .

Eslint changes are relevant for local too.

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Nov 25, 2017

extracted eslint stuff.

@ciotlosm
Copy link
Copy Markdown
Contributor

I assume this is no longer relevant?

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Jul 15, 2018

It is relevant but need to build UI that uses it. It is for Alexa and Google Assistant to decide what to expose.

@ghost ghost assigned balloob Oct 12, 2018
@ghost ghost added the in progress label Oct 12, 2018
@balloob balloob force-pushed the add-entity-filter branch 2 times, most recently from 1907d28 to a0611c2 Compare October 12, 2018 12:34
@balloob balloob changed the base branch from master to dev October 27, 2018 08:55
@balloob balloob force-pushed the add-entity-filter branch 2 times, most recently from 6cfd142 to 95eb6db Compare November 5, 2018 10:14
@balloob balloob changed the title Add entity filter util function Expose entities for Google/Alexa Nov 5, 2018
@balloob
Copy link
Copy Markdown
Member Author

balloob commented Nov 5, 2018

image

@balloob balloob mentioned this pull request Nov 5, 2018
3 tasks
@balloob
Copy link
Copy Markdown
Member Author

balloob commented Nov 5, 2018

Blocked by converting tests to TS first.

@balloob balloob mentioned this pull request Nov 5, 2018
@balloob balloob merged commit e2b9893 into dev Nov 6, 2018
@ghost ghost removed the in progress label Nov 6, 2018
@balloob balloob deleted the add-entity-filter branch November 6, 2018 13:23
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants