Conversation
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.eslintrc:
.eslintrc: Configuration for rule "import/extensions" is invalid: Severity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed '"always"').Error: .eslintrc:
at validateRuleOptions (/app/node_modules/eslint/lib/config/config-validator.js:113:15)
at Object.keys.forEach.id (/app/node_modules/eslint/lib/config/config-validator.js:153:9)
at Array.forEach ()
at validateRules (/app/node_modules/eslint/lib/config/config-validator.js:152:30)
at Object.validate (/app/node_modules/eslint/lib/config/config-validator.js:230:5)
at loadFromDisk (/app/node_modules/eslint/lib/config/config-file.js:549:19)
at Object.load (/app/node_modules/eslint/lib/config/config-file.js:592:20)
at Config.getLocalConfigHierarchy (/app/node_modules/eslint/lib/config.js:226:44)
at Config.getConfigHierarchy (/app/node_modules/eslint/lib/config.js:180:43)
at Config.getConfigVector (/app/node_modules/eslint/lib/config.js:285:21)
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.eslintrc:
.eslintrc: Configuration for rule "import/extensions" is invalid: Severity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed '"always"').Error: .eslintrc:
at validateRuleOptions (/app/node_modules/eslint/lib/config/config-validator.js:113:15)
at Object.keys.forEach.id (/app/node_modules/eslint/lib/config/config-validator.js:153:9)
at Array.forEach ()
at validateRules (/app/node_modules/eslint/lib/config/config-validator.js:152:30)
at Object.validate (/app/node_modules/eslint/lib/config/config-validator.js:230:5)
at loadFromDisk (/app/node_modules/eslint/lib/config/config-file.js:549:19)
at Object.load (/app/node_modules/eslint/lib/config/config-file.js:592:20)
at Config.getLocalConfigHierarchy (/app/node_modules/eslint/lib/config.js:226:44)
at Config.getConfigHierarchy (/app/node_modules/eslint/lib/config.js:180:43)
at Config.getConfigVector (/app/node_modules/eslint/lib/config.js:285:21)
| @@ -0,0 +1,88 @@ | |||
| import entityFilter from '../../../js/common/util/entity_filter'; | |||
There was a problem hiding this comment.
Missing file extension for "../../../js/common/util/entity_filter" import/extensions
|
I think each new function should have at least one (non test) use |
|
Is the lint change specific for hound or is it relevant for local eslint too? |
dfe22dc to
4eaba14
Compare
2afd23e to
d6587cf
Compare
|
extracted eslint stuff. |
|
I assume this is no longer relevant? |
|
It is relevant but need to build UI that uses it. It is for Alexa and Google Assistant to decide what to expose. |
d6587cf to
f149f93
Compare
1907d28 to
a0611c2
Compare
6cfd142 to
95eb6db
Compare
|
Blocked by converting tests to TS first. |
ddda31a to
93a6994
Compare
dcb1c02 to
960ef88
Compare

This ports the entity filter function from Home Assistant from Python to JavaScript. We will be able to use this function to power a user interface for exposing entities for Google Assistant, Emulated Hue, Alexa (as per #679)
Implemented function on the cloud dashboard.
Requires: home-assistant/core#18216