Rework ZHA group adds and removes#5602
Conversation
dmulcahey
changed the title
dmulcahey
changed the title
dmulcahey
changed the title
dmulcahey
force-pushed
the
dm/rework-zha-group-adds-removes
branch
from
2e1fa05 to
b91ca92
Compare
| html`<div | ||
| class="mdc-data-table__cell table-cell-text" | ||
| > |
There was a problem hiding this comment.
Why create multiple cells in a cell?
There was a problem hiding this comment.
It's how I got the associated entities to render correctly like this, including the elided text. Does that make sense?
There was a problem hiding this comment.
We should not do that, also, what happens when there are 12 entities?
There was a problem hiding this comment.
We don't have anything where that would be possible yet... if it comes to pass and we have a situation like that I can elide the list too. Do you have any suggestions?
There was a problem hiding this comment.
Add style="overflow: hidden; text-overflow: ellipsis;" instead of the classes.
There was a problem hiding this comment.
So it is not possible that there are more than 3 entities associated with a groupable device?
dmulcahey
force-pushed
the
dm/rework-zha-group-adds-removes
branch
from
b91ca92 to
62257ed
Compare
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
dmulcahey
force-pushed
the
dm/rework-zha-group-adds-removes
branch
from
b58b73a to
8b30334
Compare
|
@bramkragten any chance we can get this done before the beta? If not, I'll have to revert the PR on core. |
|
Yeah should not be a problem |
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
3 participants
Proposed change
This PR fixes the grouping UI so that it works based on endpoints and not based on devices.
REQUIRES: home-assistant/core#34583
A full explanation can be found in the description of the linked PR.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: