Group by endpoints and not by devices for ZHA Zigbee groups#34583
Merged
Adminiuga merged 20 commits intoMay 4, 2020
Conversation
|
Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration ( |
9 tasks
Adminiuga
approved these changes
Apr 23, 2020
Contributor
Adminiuga
left a comment
Adminiuga
left a comment
There was a problem hiding this comment.
Overall looks good, just a few coments.
Contributor
|
just 0.01% bellow target coverage :) |
dmulcahey
force-pushed
the
dm/zha-group-endpoints-not-devices
branch
2 times, most recently
from
5252ef7 to
0211fa2
Compare
Contributor
|
is coverage being flakey? |
Contributor
Author
|
I thought so at first but I caught a couple issues with the tests because of it... |
dmulcahey
force-pushed
the
dm/zha-group-endpoints-not-devices
branch
6 times, most recently
from
ad3d571 to
8280805
Compare
Contributor
|
Was this rebased against latest dev? I think there were some fixes for the tests. |
dmulcahey
force-pushed
the
dm/zha-group-endpoints-not-devices
branch
from
8280805 to
5a19c25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR changes how we group ZHA devices in Zigbee groups. Previously we were adding devices to groups because I misunderstood the API and some of the use cases.
Devices have multiple endpoints and the endpoints are individually group-able. EX: you have a 2 gang light switch where the left switch controls lights in 1 room (dining room for example) and the right switch controls lights in another (kitchen for example). The way groups worked before you weren't able to add the left switch to a group with other devices in the same room. If you did you ended up with the right switch in the group as well.
This PR fixes this and now endpoints can be grouped independently.
Related Frontend PR: home-assistant/frontend#5602
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: