New layout for integration config#5580
Merged
bramkragten merged 6 commits intodevfrom Apr 22, 2020
Merged
Conversation
balloob
reviewed
Apr 20, 2020
balloob
approved these changes
Apr 20, 2020
Contributor
|
Awesome! 🎉 Minor visual nitpick, I think it'd look a bit cleaner by removing the underline on the links ("X devices and X entities" part). The underlines make it a little harder to read IMO and you can already tell they're links based on the color. |
Member
|
@SeanPM5 This could be done locally, but would probably make more sense to change all links to follow this style (no underline) by default otherwise it would introduce a design inconsistency IMHO. May be a topic for somewhere else though 😃 |
4 tasks
balloob
reviewed
Apr 21, 2020
| </h3> | ||
| <a | ||
| href="/config/integrations#${relatedConfigEntryId}" | ||
| href="/config/integrations?config_entry=${relatedConfigEntryId}" |
Member
There was a problem hiding this comment.
We should still keep it as a #
Suggested change
| href="/config/integrations?config_entry=${relatedConfigEntryId}" | |
| href="/config/integrations#config_entry=${relatedConfigEntryId}" |
Member
Author
There was a problem hiding this comment.
Oh, figgered that was a typo as a query param is with the ? right? This would be a hash param :-)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Needs some cleanup and translations still.
Preview screencapture
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: