Add Icons to Discovered Integrations#5502
Closed
timmo001 wants to merge 3 commits intohome-assistant:devfrom
timmo001:integrations-icons
Closed
Add Icons to Discovered Integrations#5502timmo001 wants to merge 3 commits intohome-assistant:devfrom timmo001:integrations-icons
timmo001 wants to merge 3 commits intohome-assistant:devfrom
timmo001:integrations-icons
Conversation
bramkragten
reviewed
Apr 15, 2020
Comment on lines
+161
to
+163
| srcset=" | ||
| https://brands.home-assistant.io/${flow.handler}/icon@2x.png 2x | ||
| " |
Member
There was a problem hiding this comment.
We removed these because we don't use them big enough to need it.
bramkragten
reviewed
Apr 15, 2020
| margin: 2px 0; | ||
| } | ||
| .discovered img { | ||
| width: 36px; |
Member
There was a problem hiding this comment.
Why not the same width as the integrations?
Member
Author
There was a problem hiding this comment.
Seems to take up quite a bit of space, but I can remove that so they match
Member
|
We are working on an overhaul of this page, so not sure how long this will stay. |
bramkragten
approved these changes
Apr 15, 2020
Member
Author
|
I'll close this. #5580 supersedes this change. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Checklist