Skip to content

Card Picker: Fix Clicking cards #5425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zsarnett merged 2 commits into from
Apr 2, 2020
Merged

Card Picker: Fix Clicking cards #5425

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b6fe64
fix
zsarnett Apr 2, 2020
4a8360e
reviews
zsarnett Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/panels/lovelace/editor/card-editor/hui-card-picker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ export class HuiCardPicker extends LitElement {
background: var(--primary-background-color, #fafafa);
cursor: pointer;
box-sizing: border-box;
position: relative;
}

.card-header {
Expand Down Expand Up @@ -242,6 +243,13 @@ export class HuiCardPicker extends LitElement {
align-items: center;
justify-content: center;
}

.overlay {
position: absolute;
width: 100%;
height: 100%;
z-index: 1;
Copy link
Copy Markdown
Member

@bramkragten bramkragten Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed I think?

Copy link
Copy Markdown
Contributor Author

@zsarnett zsarnett Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed. Otherwise I can still toggle

}
`,
];
}
Expand Down Expand Up @@ -297,7 +305,12 @@ export class HuiCardPicker extends LitElement {
}

return html`
<div class="card" @click="${this._cardPicked}" .config="${cardConfig}">
<div class="card">
<div
class="overlay"
@click=${this._cardPicked}
.config=${cardConfig}
Comment on lines +311 to +312
Copy link
Copy Markdown
Member

@bramkragten bramkragten Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't have to move this, but it it fine.

Copy link
Copy Markdown
Contributor Author

@zsarnett zsarnett Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha I guess I didnt test with out changing. I just assumed it would be above it and not register the click on the lower element

></div>
<div
class="preview ${classMap({
description: !element || element.tagName === "HUI-ERROR-CARD",
Expand Down