Card Picker: Fix Clicking cards#5425
Merged
zsarnett merged 2 commits intohome-assistant:devfrom Apr 2, 2020
Merged
Conversation
3 tasks
bramkragten
reviewed
Apr 2, 2020
Comment on lines
+249
to
+250
| top: 0; | ||
| left: 0; |
bramkragten
reviewed
Apr 2, 2020
| left: 0; | ||
| width: 100%; | ||
| height: 100%; | ||
| z-index: 1; |
Contributor
Author
There was a problem hiding this comment.
This is needed. Otherwise I can still toggle
bramkragten
reviewed
Apr 2, 2020
Comment on lines
+311
to
+312
| @click=${this._cardPicked} | ||
| .config=${cardConfig} |
Member
There was a problem hiding this comment.
You didn't have to move this, but it it fine.
Contributor
Author
There was a problem hiding this comment.
Gotcha I guess I didnt test with out changing. I just assumed it would be above it and not register the click on the lower element
bramkragten
approved these changes
Apr 2, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: