Skip to content

Add more info to system log#4899

Merged
balloob merged 3 commits into
devfrom
system-log-update
Feb 17, 2020
Merged

Add more info to system log#4899
balloob merged 3 commits into
devfrom
system-log-update

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 17, 2020

Breaking change

Proposed change

Requires home-assistant/core#31902

Add which integration reported the error to the system log, including links to documentation and issues. Also shows the name of the logger that reported the log so it's easier to track down.

Integration name in overview:
image

Logger and links in details:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Copy Markdown
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to include util?

${integrations[idx]}:
`
: ""}
${item.source} (${item.level})
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we only show the source if not an integration and move the source to the details dialog?

Copy link
Copy Markdown
Member Author

@balloob balloob Feb 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that might make sense. It doesn't mean anything for the user.

@balloob balloob merged commit 322eef1 into dev Feb 17, 2020
@balloob balloob deleted the system-log-update branch February 17, 2020 18:20
@lock lock Bot locked and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants