Skip to content

Add logger name to system log#31902

Merged
springstan merged 1 commit into
devfrom
add-logger-name-system-log
Feb 17, 2020
Merged

Add logger name to system log#31902
springstan merged 1 commit into
devfrom
add-logger-name-system-log

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 17, 2020

Breaking change

Proposed change

Add the logger name to the system log entries. Example name is homeassistant.components.hue.bridge. This will allow us to figure out the integration in the frontend.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2020

Codecov Report

Merging #31902 into dev will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #31902   +/-   ##
=======================================
  Coverage   94.69%   94.69%           
=======================================
  Files         763      763           
  Lines       55181    55181           
=======================================
+ Hits        52252    52253    +1     
+ Misses       2929     2928    -1     
Impacted Files Coverage Δ
homeassistant/components/uk_transport/sensor.py 94.20% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00b3efe...e7afd67. Read the comment docs.

@frenck
Copy link
Copy Markdown
Member

frenck commented Feb 17, 2020

Nice! That will improve the experience when a user hits an error 👍

@springstan springstan merged commit 3da136b into dev Feb 17, 2020
@delete-merged-branch delete-merged-branch Bot deleted the add-logger-name-system-log branch February 17, 2020 16:26
@lock lock Bot locked and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants