-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Change config navigation to tabs #4630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cfda9f6
Change config navigation to tabs
bramkragten ff4fd2b
Update ha-menu-button.ts
bramkragten 4e9f8f7
Icons
bramkragten 5853a59
update
bramkragten 1a6365a
Review comments
bramkragten c45937a
configSections -> object instead of array
bramkragten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,239 @@ | ||
| import { | ||
| LitElement, | ||
| property, | ||
| TemplateResult, | ||
| html, | ||
| customElement, | ||
| css, | ||
| CSSResult, | ||
| PropertyValues, | ||
| } from "lit-element"; | ||
| import "../components/ha-menu-button"; | ||
| import "../components/ha-paper-icon-button-arrow-prev"; | ||
| import { classMap } from "lit-html/directives/class-map"; | ||
| import { Route, HomeAssistant } from "../types"; | ||
| import { navigate } from "../common/navigate"; | ||
| import "@material/mwc-ripple"; | ||
| import { isComponentLoaded } from "../common/config/is_component_loaded"; | ||
|
|
||
| export interface PageNavigation { | ||
| path: string; | ||
| translationKey?: string; | ||
| component?: string; | ||
| name?: string; | ||
| core?: boolean; | ||
| exportOnly?: boolean; | ||
| icon?: string; | ||
| info?: any; | ||
| } | ||
|
|
||
| @customElement("hass-tabs-subpage") | ||
| class HassTabsSubpage extends LitElement { | ||
| @property() public hass!: HomeAssistant; | ||
| @property({ type: String, attribute: "back-path" }) public backPath?: string; | ||
| @property() public backCallback?: () => void; | ||
| @property({ type: Boolean }) public hassio = false; | ||
| @property({ type: Boolean }) public showAdvanced = false; | ||
| @property() public route!: Route; | ||
| @property() public tabs!: PageNavigation[]; | ||
| @property({ type: Boolean, reflect: true }) public narrow = false; | ||
| @property() private _activeTab: number = -1; | ||
|
|
||
| protected updated(changedProperties: PropertyValues) { | ||
| super.updated(changedProperties); | ||
| if (changedProperties.has("route")) { | ||
| this._activeTab = this.tabs.findIndex((tab) => | ||
| this.route.prefix.includes(tab.path) | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| protected render(): TemplateResult { | ||
| return html` | ||
| <div class="toolbar"> | ||
| <ha-paper-icon-button-arrow-prev | ||
| aria-label="Back" | ||
| .hassio=${this.hassio} | ||
| @click=${this._backTapped} | ||
| ></ha-paper-icon-button-arrow-prev> | ||
| <div id="tabbar" class=${classMap({ "bottom-bar": this.narrow })}> | ||
| ${this.tabs.map((page, index) => | ||
| (!page.component || | ||
| page.core || | ||
| isComponentLoaded(this.hass, page.component)) && | ||
| (!page.exportOnly || this.showAdvanced) | ||
| ? html` | ||
| <div | ||
| class="tab ${classMap({ | ||
| active: index === this._activeTab, | ||
| })}" | ||
| @click=${this._tabTapped} | ||
| .path=${page.path} | ||
| > | ||
| ${this.narrow | ||
| ? html` | ||
| <ha-icon .icon=${page.icon}></ha-icon> | ||
| ` | ||
| : ""} | ||
| ${!this.narrow || index === this._activeTab | ||
| ? html` | ||
| <span class="name" | ||
| >${page.translationKey | ||
| ? this.hass.localize(page.translationKey) | ||
| : name}</span | ||
| > | ||
| ` | ||
| : ""} | ||
| <mwc-ripple></mwc-ripple> | ||
| </div> | ||
| ` | ||
| : "" | ||
| )} | ||
| </div> | ||
|
|
||
| <div id="toolbar-icon"> | ||
| <slot name="toolbar-icon"></slot> | ||
| </div> | ||
| </div> | ||
| <div class="content"> | ||
| <slot></slot> | ||
| </div> | ||
| `; | ||
| } | ||
|
|
||
| private _tabTapped(ev: MouseEvent): void { | ||
| navigate(this, (ev.currentTarget as any).path, true); | ||
| } | ||
|
|
||
| private _backTapped(): void { | ||
| if (this.backPath) { | ||
| navigate(this, this.backPath); | ||
| return; | ||
| } | ||
| if (this.backCallback) { | ||
| this.backCallback(); | ||
| return; | ||
| } | ||
| history.back(); | ||
| } | ||
|
|
||
| static get styles(): CSSResult { | ||
| return css` | ||
| :host { | ||
| display: block; | ||
| height: 100%; | ||
| background-color: var(--primary-background-color); | ||
| } | ||
|
|
||
| .toolbar { | ||
| display: flex; | ||
| align-items: center; | ||
| font-size: 20px; | ||
| height: 64px; | ||
| background-color: var(--sidebar-background-color); | ||
| font-weight: 400; | ||
| color: var(--sidebar-text-color); | ||
| border-bottom: 1px solid var(--divider-color); | ||
| padding: 0 16px; | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| :host([narrow]) .toolbar { | ||
| background-color: var(--primary-background-color); | ||
| border-bottom: none; | ||
| } | ||
|
|
||
| #tabbar { | ||
| display: flex; | ||
| font-size: 14px; | ||
| } | ||
|
|
||
| #tabbar.bottom-bar { | ||
| position: absolute; | ||
| bottom: 0; | ||
| left: 0; | ||
| padding: 0 16px; | ||
| box-sizing: border-box; | ||
| background-color: var(--sidebar-background-color); | ||
| border-top: 1px solid var(--divider-color); | ||
| justify-content: space-between; | ||
| z-index: 1; | ||
| font-size: 12px; | ||
| width: 100%; | ||
| } | ||
|
|
||
| #tabbar:not(.bottom-bar) { | ||
| margin: auto; | ||
| left: 50%; | ||
| position: absolute; | ||
| transform: translate(-50%, 0); | ||
| } | ||
|
|
||
| .tab { | ||
| padding: 0 32px; | ||
| display: flex; | ||
| flex-direction: column; | ||
| text-align: center; | ||
| align-items: center; | ||
| justify-content: center; | ||
| height: 64px; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| .name { | ||
| white-space: nowrap; | ||
| } | ||
|
|
||
| .tab.active { | ||
| color: var(--primary-color); | ||
| } | ||
|
|
||
| #tabbar:not(.bottom-bar) .tab.active { | ||
| border-bottom: 2px solid var(--primary-color); | ||
| } | ||
|
|
||
| .bottom-bar .tab { | ||
| padding: 0 16px; | ||
| width: 20%; | ||
| min-width: 0; | ||
| } | ||
|
|
||
| ha-menu-button, | ||
| ha-paper-icon-button-arrow-prev, | ||
| ::slotted([slot="toolbar-icon"]) { | ||
| pointer-events: auto; | ||
| color: var(--sidebar-icon-color); | ||
| } | ||
|
|
||
| [main-title] { | ||
| margin: 0 0 0 24px; | ||
| line-height: 20px; | ||
| flex-grow: 1; | ||
| } | ||
|
|
||
| .content { | ||
| position: relative; | ||
| width: 100%; | ||
| height: calc(100% - 64px); | ||
| overflow-y: auto; | ||
| overflow: auto; | ||
| -webkit-overflow-scrolling: touch; | ||
| } | ||
|
|
||
| #toolbar-icon { | ||
| position: absolute; | ||
| right: 16px; | ||
| } | ||
|
|
||
| :host([narrow]) .content { | ||
| height: calc(100% - 128px); | ||
| } | ||
| `; | ||
| } | ||
| } | ||
|
|
||
| declare global { | ||
| interface HTMLElementTagNameMap { | ||
| "hass-tabs-subpage": HassTabsSubpage; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add docstrings to each property. It's not clear to me what this property does.